Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error query with non-evm chainId when search #92

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix: error query with non-evm chainId when search #92

merged 1 commit into from
Jul 2, 2024

Conversation

tiendn
Copy link

@tiendn tiendn commented Jul 2, 2024 •
edited
Loading

Description

Add wrong query chainId when search
Issue: #91

Solution

Return only evm chain with bigint type not string

-  return { chains, mainnets, testnets };
+  // Return only evnChains because of graphql only accept query non-evm chains (with bigint type not string)
+  return { chains: coreEvmChains, mainnets, testnets };

@vercel Vercel
Copy link

vercel bot commented Jul 2, 2024

Someone is attempting to deploy a commit to the Abacus Works Team on Vercel.

A member of the Team first needs to authorize it.

jmrossy
jmrossy approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @tiendn

@jmrossy jmrossy changed the base branch from main to chain-selection-fix July 2, 2024 14:24
@jmrossy jmrossy merged commit 72cd5e2 into hyperlane-xyz:chain-selection-fix Jul 2, 2024
3 of 5 checks passed
@jmrossy jmrossy mentioned this pull request Jul 2, 2024
Merged
@tiendn tiendn deleted the fix/query-search-chain-error branch July 2, 2024 14:27
jmrossy added a commit that referenced this pull request Jul 2, 2024
@jmrossy
fix: error non-evm chain selected in filter (#93)
4718f4a 
Proxy for #92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrossy jmrossy jmrossy approved these changes

@yorhodes yorhodes Awaiting requested review from yorhodes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiendn @jmrossy @0xTylerD26